Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix perspective_reversed_z_vk for lh_yup and rh_yup #168

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fix perspective_reversed_z_vk for lh_yup and rh_yup #168

merged 1 commit into from
Feb 26, 2024

Conversation

YouSafe
Copy link
Contributor

@YouSafe YouSafe commented Feb 24, 2024

This PR fixes only the perspective_reversed_z_vk functions and not the other projection matrix constructors.

I used Mathcad to simplify matrix definitions:

image

Further references I used are:

fu5ha
fu5ha approved these changes Feb 26, 2024
View reviewed changes
Copy link
Owner

@fu5ha fu5ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@fu5ha fu5ha merged commit 377b001 into fu5ha:main Feb 26, 2024
1 of 3 checks passed
@YouSafe YouSafe deleted the fix-reverse-z branch February 26, 2024 15:02
@YouSafe YouSafe mentioned this pull request Apr 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fu5ha fu5ha fu5ha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YouSafe @fu5ha